Add more testing for AES XTS by kenneth-tucker · Pull Request #217 · Azure/azihsm-sdk

kenneth-tucker · 2026-02-26T20:08:08Z

Issue:
#200

Note: this change is based on AES GCM changes because of shared test utilities. I'll rebase this on main once that is merged. See #210

Copilot

Pull request overview

This PR expands AES-XTS test coverage in the C++ test suite and refactors shared AES test utilities so CBC/GCM/XTS tests can reuse common helper routines. It also adds an AES-XTS unwrap/unmask precheck at the Rust DDI layer to fail earlier on unusable XTS key pairs.

Changes:

Added extensive AES-XTS encryption/decryption correctness, validation, and malformed-input coverage in C++ tests.
Introduced shared AES C++ test helpers (helpers.hpp/.cpp) and updated CBC/GCM/XTS tests to use them; removed the old kat.cpp/hpp.
Added a minimal XTS “operability” precheck during unwrap/unmask in aes_xts_key.rs.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
api/tests/cpp/handle_mgmt_tests.cpp	Switches AES key generation helper used by handle-management tests to the new CBC helper.
api/tests/cpp/algo/aes/xts_enc_dec_tests.cpp	Major expansion of AES-XTS test coverage plus new blob-wrap/unmask/unwrap negative tests.
api/tests/cpp/algo/aes/helpers.hpp	Adds shared test helper declarations/types (crypt wrappers, generators, sweeps, KAT structs).
api/tests/cpp/algo/aes/helpers.cpp	Implements shared AES test helpers and key generators; migrates KAT import helper here.
api/tests/cpp/algo/aes/gcm_enc_dec_tests.cpp	Refactors to use shared helpers and adds more AES-GCM coverage.
api/tests/cpp/algo/aes/cbc_enc_dec_tests.cpp	Refactors to use shared helpers; adjusts KAT import call to new signature.
api/tests/cpp/algo/aes/kat.hpp	Deleted (KAT structs/utilities moved into shared helpers).
api/tests/cpp/algo/aes/kat.cpp	Deleted (KAT import helper moved into shared helpers implementation).
api/tests/cpp/CMakeLists.txt	Replaces `kat.cpp` with `helpers.cpp` in the test build.
api/lib/src/ddi/aes_xts_key.rs	Adds unwrap/unmask XTS pair operability precheck; introduces new helper function.

api/lib/src/ddi/aes_xts_key.rs

api/tests/cpp/algo/aes/xts_enc_dec_tests.cpp

api/lib/src/ddi/aes_xts_key.rs

api/tests/cpp/algo/aes/helpers.cpp

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

api/tests/cpp/algo/aes/helpers.cpp

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

api/tests/cpp/algo/aes/xts_enc_dec_tests.cpp

api/tests/cpp/algo/aes/helpers.cpp

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

api/tests/cpp/algo/aes/xts_enc_dec_tests.cpp

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

api/tests/cpp/algo/aes/xts_enc_dec_tests.cpp

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

api/tests/cpp/algo/aes/xts_enc_dec_tests.cpp

mhatrevi

🕐

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

api/tests/cpp/algo/aes/xts_enc_dec_tests.cpp

…nd key2 match. This was needed to fix the failing test case, azihsm_aes_xts.unwrap_xts_blob_identical_halves_is_rejected.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

api/tests/cpp/algo/aes/xts_enc_dec_tests.cpp

api/tests/cpp/utils/key_import.cpp

kenneth-tucker requested review from meilu-git and mhatrevi February 26, 2026 20:08

kenneth-tucker self-assigned this Feb 26, 2026

kenneth-tucker force-pushed the user/v-ktucker/200-more-testing-aes-xts branch 2 times, most recently from ea90eb2 to 3f5c76a Compare February 26, 2026 22:04

kenneth-tucker requested a review from Copilot February 26, 2026 22:14

Copilot started reviewing on behalf of kenneth-tucker February 26, 2026 22:15 View session

Copilot AI reviewed Feb 26, 2026

View reviewed changes

api/lib/src/ddi/aes_xts_key.rs Outdated Show resolved Hide resolved

api/lib/src/ddi/aes_xts_key.rs Outdated Show resolved Hide resolved

api/tests/cpp/algo/aes/xts_enc_dec_tests.cpp Outdated Show resolved Hide resolved

mhatrevi reviewed Feb 27, 2026

View reviewed changes

api/lib/src/ddi/aes_xts_key.rs Outdated Show resolved Hide resolved

mhatrevi reviewed Feb 27, 2026

View reviewed changes

api/tests/cpp/algo/aes/helpers.cpp Outdated Show resolved Hide resolved

mhatrevi reviewed Feb 27, 2026

View reviewed changes

api/tests/cpp/algo/aes/helpers.cpp Show resolved Hide resolved

kenneth-tucker mentioned this pull request Feb 27, 2026

Consider additional validation for aes_xts_unwrap_key and add back unwrap_xts_blob_identical_halves_is_rejected test case #224

Open

Copilot AI review requested due to automatic review settings February 27, 2026 23:53

kenneth-tucker force-pushed the user/v-ktucker/200-more-testing-aes-xts branch from bf64920 to dd7b746 Compare February 27, 2026 23:53

Copilot started reviewing on behalf of kenneth-tucker February 27, 2026 23:53 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

api/tests/cpp/algo/aes/helpers.cpp Show resolved Hide resolved

kenneth-tucker force-pushed the user/v-ktucker/200-more-testing-aes-xts branch 2 times, most recently from ceeca14 to 6c32ee2 Compare March 2, 2026 18:57

Copilot AI review requested due to automatic review settings March 2, 2026 18:57

Copilot started reviewing on behalf of kenneth-tucker March 2, 2026 18:58 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

kenneth-tucker force-pushed the user/v-ktucker/200-more-testing-aes-xts branch from 6c32ee2 to 0cca762 Compare March 2, 2026 19:30

kenneth-tucker requested a review from Copilot March 2, 2026 19:30

Copilot started reviewing on behalf of kenneth-tucker March 2, 2026 19:31 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

api/tests/cpp/algo/aes/xts_enc_dec_tests.cpp Show resolved Hide resolved

api/tests/cpp/algo/aes/helpers.cpp Show resolved Hide resolved

kenneth-tucker force-pushed the user/v-ktucker/200-more-testing-aes-xts branch from 0cca762 to 90dcaba Compare March 2, 2026 19:53

Copilot AI review requested due to automatic review settings March 2, 2026 21:08

kenneth-tucker force-pushed the user/v-ktucker/200-more-testing-aes-xts branch from 90dcaba to 06c2b01 Compare March 2, 2026 21:08

Copilot started reviewing on behalf of kenneth-tucker March 2, 2026 21:09 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

api/tests/cpp/algo/aes/xts_enc_dec_tests.cpp Outdated Show resolved Hide resolved

Copilot AI review requested due to automatic review settings March 6, 2026 17:16

kenneth-tucker force-pushed the user/v-ktucker/200-more-testing-aes-xts branch from c9b0cdc to 59245d9 Compare March 6, 2026 17:16

Copilot started reviewing on behalf of kenneth-tucker March 6, 2026 17:17 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

api/tests/cpp/algo/aes/xts_enc_dec_tests.cpp Outdated Show resolved Hide resolved

kenneth-tucker force-pushed the user/v-ktucker/200-more-testing-aes-xts branch from 59245d9 to 279e9be Compare March 6, 2026 17:58

Copilot AI review requested due to automatic review settings March 6, 2026 18:41

kenneth-tucker force-pushed the user/v-ktucker/200-more-testing-aes-xts branch from 279e9be to 7f80b61 Compare March 6, 2026 18:41

Copilot started reviewing on behalf of kenneth-tucker March 6, 2026 18:43 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

api/tests/cpp/algo/aes/xts_enc_dec_tests.cpp Outdated Show resolved Hide resolved

mhatrevi reviewed Mar 9, 2026

View reviewed changes

api/tests/cpp/algo/aes/xts_enc_dec_tests.cpp Outdated Show resolved Hide resolved

mhatrevi requested changes Mar 9, 2026

View reviewed changes

kenneth-tucker force-pushed the user/v-ktucker/200-more-testing-aes-xts branch from 7f80b61 to f21e8a2 Compare March 10, 2026 00:18

Copilot AI review requested due to automatic review settings March 10, 2026 18:47

kenneth-tucker force-pushed the user/v-ktucker/200-more-testing-aes-xts branch from f21e8a2 to 2644ac6 Compare March 10, 2026 18:47

Copilot started reviewing on behalf of kenneth-tucker March 10, 2026 18:48 View session

kenneth-tucker enabled auto-merge (squash) March 10, 2026 18:52

Copilot AI reviewed Mar 10, 2026

View reviewed changes

api/tests/cpp/algo/aes/xts_enc_dec_tests.cpp Show resolved Hide resolved

api/tests/cpp/algo/aes/xts_enc_dec_tests.cpp Show resolved Hide resolved

kenneth-tucker added 6 commits March 11, 2026 10:49

Scaffold test cases and helpers for AES XTS

75e8521

Generate AES XTS test body content

c3063ff

Add check for AES XTS key unwrap/unmask to catch problem where key1 a…

e61e756

…nd key2 match. This was needed to fix the failing test case, azihsm_aes_xts.unwrap_xts_blob_identical_halves_is_rejected.

Fix review feedback

a5192d0

Fix more review feedback

947d441

Refactor XTS blob construction and fix naming conflict

ca026d9

kenneth-tucker force-pushed the user/v-ktucker/200-more-testing-aes-xts branch from 2644ac6 to ca026d9 Compare March 11, 2026 17:49

mhatrevi approved these changes Mar 12, 2026

View reviewed changes

Merge branch 'main' into user/v-ktucker/200-more-testing-aes-xts

6a91974

Copilot AI review requested due to automatic review settings March 12, 2026 17:08

Copilot started reviewing on behalf of mhatrevi March 12, 2026 17:09 View session

Copilot AI reviewed Mar 12, 2026

View reviewed changes

api/tests/cpp/algo/aes/xts_enc_dec_tests.cpp Show resolved Hide resolved

api/tests/cpp/algo/aes/xts_enc_dec_tests.cpp Show resolved Hide resolved

api/tests/cpp/utils/key_import.cpp Show resolved Hide resolved

kenneth-tucker merged commit 470fcf6 into main Mar 12, 2026
11 checks passed

Conversation

kenneth-tucker commented Feb 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

mhatrevi left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants